[PATCH] D109448: [IRSim][IROutliner] Treating Called Functions as Values and Outlining Indirect Calls

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:132
+  /// This is only relevant if we are wrapping a CallInst and we are requiring
+  // that the name of the function called be the same.
+  Optional<std::string> CallInstName;
----------------



================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:133
+  // that the name of the function called be the same.
+  Optional<std::string> CallInstName;
+
----------------
Can the comment include what this actually is used for?


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:199
+  /// \param MatchByName - A flag to mark whether we are using the called
+  /// function name as a differentiating parameter.
+  void setFunctionName(bool MatchByName = true);
----------------
Can the comment explain why you would/wouldn't match by name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109448/new/

https://reviews.llvm.org/D109448