[PATCH] D109377: type legalization for vp_load and vp_store.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7700
     // Extending load.
-    assert(MemVT.getScalarType().bitsLT(VT.getScalarType()) &&
+    assert(MemVT.getScalarType().bitsLE(VT.getScalarType()) &&
            "Should only be an extending load, not truncating!");
----------------
hussainjk wrote:
> craig.topper wrote:
> > Why should this be different than the assert in getLoad?
> These assertions fail on cases that masked loads do not.
But why? Seems weird to have an extending load that doesn't extend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109377/new/

https://reviews.llvm.org/D109377