[PATCH] D109379: Implementation of PPC lowering for vp_load/vp_store with no mask

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15249
+      SmallVector<SDValue, 5> NewOps(N->op_begin(), N->op_end());
+      NewOps[4] = ShiftedLength;
+      return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
----------------
should this be NewOps[3] instead?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15276
+      SmallVector<SDValue, 5> NewOps(N->op_begin(), N->op_end());
+      NewOps[5] = ShiftedLength;
+      return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
----------------
5 seems out or range. Shouldn't it be `NewOps[4] = ShiftedLength;` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109379/new/

https://reviews.llvm.org/D109379