[PATCH] D109377: type legalization for vp_load and vp_store.

Hussain Kadhem via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 10:48:19 PDT 2021


hussainjk added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7700
     // Extending load.
-    assert(MemVT.getScalarType().bitsLT(VT.getScalarType()) &&
+    assert(MemVT.getScalarType().bitsLE(VT.getScalarType()) &&
            "Should only be an extending load, not truncating!");
----------------
craig.topper wrote:
> Why should this be different than the assert in getLoad?
These assertions fail on cases that masked loads do not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109377/new/

https://reviews.llvm.org/D109377



More information about the llvm-commits mailing list