[PATCH] D107533: Handle encoding personalities of same names but different kinds.

Fri Sep 10 10:21:31 PDT 2021

oontvoo marked an inline comment as done.
oontvoo added inline comments.

================
Comment at: lld/MachO/UnwindInfoSection.cpp:188-191
+    //    - if all 3 present, local is picked
+    //    - if {dylib, local}, dylib is picked
+    //    - if {dylib, global}, global
+    //    - if {local, global}, local
----------------
int3 wrote:
> omg... I assume you've verified that this what ld64 does? this seems super bizarre. It's not even a valid total order!
Yeah - the last two I could understand a little.  The first two are completely unexpected.
Now that we're here, actually. I, personally, would be fine with LLD re-defining its own rules - as long as it's consistent.

(The problem I'm trying to fix here is the duplicate personality symbols - hence as long as we have a set of rules to pick one, i'm good)
Any inclination on which way to go from here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107533/new/

https://reviews.llvm.org/D107533