[PATCH] D109548: Make llvm.launder.invariant.group writeonly

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 09:01:30 PDT 2021


jdoerfert added a comment.

In D109548#2994754 <https://reviews.llvm.org/D109548#2994754>, @nikic wrote:

> Generally though, I think we should consider adding a new attribute to mark intrinsics like this, rather than using inaccessiblememonly. Ideally we don't want to mix these up with memory effects, and just want to say "don't remove or CSE this intrinsic" ("do not hoist" is already implied by lack of speculatable).

I think we should revisit our attribute system for effects and make it flexible enough that "don't remove or cse this intrinsic" falls out as a special case which is not interacting with anything else.
We'll send an RFC today for global effects, after that I want to start a discussion on a flexible system.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109548/new/

https://reviews.llvm.org/D109548



More information about the llvm-commits mailing list