[PATCH] D109537: [InstCombine] move extend after insertelement if both operands are extended

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 08:56:18 PDT 2021


RKSimon added a comment.

In D109537#2994425 <https://reviews.llvm.org/D109537#2994425>, @spatel wrote:

> In D109537#2994331 <https://reviews.llvm.org/D109537#2994331>, @spatel wrote:
>
>> In D109537#2992713 <https://reviews.llvm.org/D109537#2992713>, @RKSimon wrote:
>>
>>> Should we handle trunc as well? https://alive2.llvm.org/ce/z/93QN9g
>>
>> I want to check that codegen isn't impacted by using insertelement on a wider (possible illegal type) vector op, but I think the answer is 'yes'.
>
> We would need to deal with something like this in the backend to be safe:
> https://godbolt.org/z/E1nKvd6e3

Yeah, there's going to be a number of these - in particular for integer insertions


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109537/new/

https://reviews.llvm.org/D109537



More information about the llvm-commits mailing list