[PATCH] D109503: [stack-safety] Allow to determine safe accesses.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 07:53:21 PDT 2021


fmayer added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:361
           US.addRange(I, UnknownRange);
-          return;
+          break;
         }
----------------
vitalybuka wrote:
> I see why you need "break" instead of "return" in these cases.
> However I tried to revert this part and no tests failed.
> 
> Could you please to add a test-case sensitive to this part of the patch. Please cover at least few of these breaks.
> 
Added tests covering most of the return -> break cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109503/new/

https://reviews.llvm.org/D109503



More information about the llvm-commits mailing list