[PATCH] D109604: [Hexagon] NFC: Remove unused tblgen template args

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 06:46:40 PDT 2021


c-rhodes created this revision.
c-rhodes added a reviewer: kparzysz.
Herald added a subscriber: hiraditya.
c-rhodes requested review of this revision.
Herald added a project: LLVM.

Identified in D109359 <https://reviews.llvm.org/D109359>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109604

Files:
  llvm/lib/Target/Hexagon/HexagonInstrFormats.td
  llvm/lib/Target/Hexagon/HexagonPseudo.td


Index: llvm/lib/Target/Hexagon/HexagonPseudo.td
===================================================================
--- llvm/lib/Target/Hexagon/HexagonPseudo.td
+++ llvm/lib/Target/Hexagon/HexagonPseudo.td
@@ -198,7 +198,7 @@
 let isCall = 1, hasSideEffects = 1,
     isExtended = 0, isExtendable = 1, opExtendable = 0, isCodeGenOnly = 1,
     BaseOpcode = "PS_call_nr", isExtentSigned = 1, opExtentAlign = 2 in
-class Call_nr<bits<5> nbits, bit isPred, bit isFalse, dag iops,
+class Call_nr<bits<5> nbits, bit isFalse, dag iops,
               InstrItinClass itin>
   : Pseudo<(outs), iops, "">, PredRel {
     bits<2> Pu;
@@ -210,7 +210,7 @@
     let Itinerary = itin;
 }
 
-def PS_call_nr : Call_nr<24, 0, 0, (ins s32_0Imm:$Ii), J2_call.Itinerary>;
+def PS_call_nr : Call_nr<24, 0, (ins s32_0Imm:$Ii), J2_call.Itinerary>;
 //def PS_call_nrt: Call_nr<17, 1, 0, (ins PredRegs:$Pu, s32_0Imm:$dst),
 //                         J2_callt.Itinerary>;
 //def PS_call_nrf: Call_nr<17, 1, 1, (ins PredRegs:$Pu, s32_0Imm:$dst),
@@ -267,7 +267,7 @@
 class CondStr<string CReg, bit True, bit New> {
   string S = "if (" # !if(True,"","!") # CReg # !if(New,".new","") # ") ";
 }
-class JumpOpcStr<string Mnemonic, bit New, bit Taken> {
+class JumpOpcStr<string Mnemonic, bit Taken> {
   string S = Mnemonic # !if(Taken, ":t", ":nt");
 }
 let isBranch = 1, isIndirectBranch = 1, Defs = [PC], isPredicated = 1,
@@ -275,7 +275,7 @@
 class T_JMPr_c <bit PredNot, bit isPredNew, bit isTak, InstHexagon rootInst>
   :  InstHexagon<(outs), (ins PredRegs:$src, IntRegs:$dst),
                  CondStr<"$src", !if(PredNot,0,1), isPredNew>.S #
-                 JumpOpcStr<"jumpr", isPredNew, isTak>.S # " $dst",
+                 JumpOpcStr<"jumpr", isTak>.S # " $dst",
                  [], "", rootInst.Itinerary, rootInst.Type>, OpcodeHexagon {
 
     let isTaken = isTak;
Index: llvm/lib/Target/Hexagon/HexagonInstrFormats.td
===================================================================
--- llvm/lib/Target/Hexagon/HexagonInstrFormats.td
+++ llvm/lib/Target/Hexagon/HexagonInstrFormats.td
@@ -268,8 +268,7 @@
   let Inst{12-0}  = ISubLo;
 }
 
-class InstDuplex<bits<4> iClass, list<dag> pattern = [],
-                 string cstr = "">
+class InstDuplex<bits<4> iClass, string cstr = "">
   : Instruction, OpcodeDuplex {
   let Namespace = "Hexagon";
   IType Type = TypeDUPLEX;  // uses slot 0,1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109604.371916.patch
Type: text/x-patch
Size: 2390 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210910/4c8b0804/attachment.bin>


More information about the llvm-commits mailing list