[PATCH] D109513: [AsmPrinter, SystemZ] Allow target to add instructions before section is ended.

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

In D109513#2994352 <https://reviews.llvm.org/D109513#2994352>, @jonpa wrote:

> In D109513#2994113 <https://reviews.llvm.org/D109513#2994113>, @uweigand wrote:
>
>> In D109513#2994077 <https://reviews.llvm.org/D109513#2994077>, @jonpa wrote:
>>
>>> In D109513#2992888 <https://reviews.llvm.org/D109513#2992888>, @aeubanks wrote:
>>>
>>>> do you think it'd make sense to merge emitConstantPools into emitSectionEndings?
>>>
>>> How about moving emitConstantPools() into the default implementation of emitSectionEndings() like this..?
>>
>> Hmm ... that makes me wonder:  can we instead just use the existing emitConstantPools in the SystemZ back end to output the EXRL instructions?  They are in effect a form of constants ...   That shouldn't require any common code changes then.
>
> I read in the original bug report: "...adding the XC instructions in some other text section out of the eyes of debug is not a good option for z/OS (details excluded)". Therefore I thought they better be placed in the text section...

Can't a back-end specific emitConstantPools hook just emit those into the .text section?   It's called at the same point you proposed new hook would be called, so I thought it should be able to do the same thing ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109513/new/

https://reviews.llvm.org/D109513