[PATCH] D109513: [AsmPrinter, SystemZ] Allow target to add instructions before section is ended.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 03:17:13 PDT 2021


uweigand added a comment.

In D109513#2994077 <https://reviews.llvm.org/D109513#2994077>, @jonpa wrote:

> In D109513#2992888 <https://reviews.llvm.org/D109513#2992888>, @aeubanks wrote:
>
>> do you think it'd make sense to merge emitConstantPools into emitSectionEndings?
>
> How about moving emitConstantPools() into the default implementation of emitSectionEndings() like this..?

Hmm ... that makes me wonder:  can we instead just use the existing emitConstantPools in the SystemZ back end to output the EXRL instructions?  They are in effect a form of constants ...   That shouldn't require any common code changes then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109513/new/

https://reviews.llvm.org/D109513



More information about the llvm-commits mailing list