[PATCH] D109572: [ELF] Add --why-extract to query why an archive member/lazy object file is extracted

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 01:21:24 PDT 2021


jhenderson added a comment.

Some conflicting thoughts:

1. Maybe this should be part of the --verbose (or possibly --trace) output?
2. If not doing the above, maybe it should be in a separate file?
3. If printing it to stdout is still desired, and not under another existing option, I think it might be better to group the output into one block somewhere. If you combine the new option with e.g. --verbose or --trace, I expect you'll get interleaved and potentially confusing output, esepcially as the table header will be divorced from the rest of the table content.



================
Comment at: lld/test/ELF/why-extract.s:15-17
+#      CHECK:reference	extracted	symbol
+# CHECK-NEXT:main.o	a_b.a(a_b.o)	a
+# CHECK-NEXT:a_b.a(a_b.o)	b.a(b.o)	b()
----------------
I'm not entirely sure what the right solution here is, but I think this output needs to be better tabulated, so that the columns line up (possibly with the exception of long names). Possibly alternatively, rather than using tabs to separate, how about some other symbol like `;` or `|`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109572/new/

https://reviews.llvm.org/D109572



More information about the llvm-commits mailing list