[PATCH] D106940: Fix test for debug dir presence

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 00:48:52 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. Do you plan on making more LLVM contributions in the future? If so, given you've now got a couple of commits landed in your name successfully (I'm assuming the yaml2obj one did land successfully), I think you can request commit access for yourself. Otherwise, let me know if you'd like me to commit on your behalf.



================
Comment at: llvm/test/tools/llvm-objcopy/COFF/check-debug-dir-present.test:5
+# RUN: llvm-objcopy --add-section new_sect=%t %t %t1
+# RUN: obj2yaml %t1 | FileCheck %s --check-prefixes=CHECK
+
----------------
As said already, CHECK is the default check prefix and so doesn't need specifying (as long as no other --check-prefix/--check-prefixes commands are used in that invocation).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106940/new/

https://reviews.llvm.org/D106940



More information about the llvm-commits mailing list