[PATCH] D109441: [FuncSpec] Don't specialise call sites that have the MinSize attribute set
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 10 00:37:28 PDT 2021
SjoerdMeijer added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:663
+ if (CS.hasFnAttr(Attribute::MinSize))
+ continue;
----------------
ChuanqiXu wrote:
> We need to mark `AllConstant` as false before we continue. Otherwise it is possible that the original function may be considered as unreachable incorrectly.
Will add that before committing.
Thanks both for reviewing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109441/new/
https://reviews.llvm.org/D109441
More information about the llvm-commits
mailing list