[PATCH] D109354: [LoopBoundSplit] Check the start value of split cond AddRec

JinGu Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 23:45:17 PDT 2021


jaykang10 added a comment.

In D109354#2993410 <https://reviews.llvm.org/D109354#2993410>, @mkazantsev wrote:

> If it's still a work in progess change, you can as well use "Plan changes" to withdraw it from review list.

I am sorry for changing patch frequently. If possible, I would like to get review with current patch.



================
Comment at: llvm/test/Transforms/LoopBoundSplit/loop-bound-split.ll:6
+; split condition is always true in pre-loop after transformation.
+define void @variable_split_loop_bound_inc_with_sgt(i64 %a, i64* noalias %src, i64* noalias %dst, i64 %n) {
+; CHECK-LABEL: @variable_split_loop_bound_inc_with_sgt(
----------------
mkazantsev wrote:
> This test's name is confusing. There is no `sgt` inside (and same with the next one).
Ah, sorry... The `sgt` is for loop exit condition. Let me update the test names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109354/new/

https://reviews.llvm.org/D109354



More information about the llvm-commits mailing list