[PATCH] D109377: Integer type legalization for vp_load and vp_store.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1933
+
+  assert(!N->isIndexed() && "expecting unindexed vp_store!");
+
----------------
Why does this use isIndexed() but load uses `N->getAddressingMode() == ISD::UNINDEXED`. Are the interfaces for checking indexed different for loads and stores?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7700
     // Extending load.
-    assert(MemVT.getScalarType().bitsLT(VT.getScalarType()) &&
+    assert(MemVT.getScalarType().bitsLE(VT.getScalarType()) &&
            "Should only be an extending load, not truncating!");
----------------
Why should this be different than the assert in getLoad?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109377/new/

https://reviews.llvm.org/D109377