[PATCH] D109564: [X86][NFC] Remove unused encoding string: VK[1/2/4/8/16]PAIR

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D109564#2993400 <https://reviews.llvm.org/D109564#2993400>, @xiangzhangllvm wrote:

> Change VK1PAIR to VK1Pair may be reasonable. (keep same with other xxRegisterEncodingFromString for future ISA.)
>
> lib/Target/X86/X86RegisterInfo.td:629:def VK1PAIR   : RegisterClass<"X86", [untyped], 16, (add KPAIRS)> {let Size = 32;}
> lib/Target/X86/X86InstrInfo.td:817:def VK1Pair : RegisterOperand<VK1PAIR, "printVKPair"> {

I think it is fine to remove it. Tablegen will issue an error if a new instruction is added. At that point its easy to add back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109564/new/

https://reviews.llvm.org/D109564