[PATCH] D109412: [MC] Make MCDwarfLineStr class public

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 18:13:31 PDT 2021


maksfb added a comment.

>>  Note that MCDwarfLineTableHeader::Emit(), takes MCDwarfLineStr as an Optional<> parameter making it impossible to use the API if the class is not publicly defined.
>
> Presumably you could still pass `None` to such an API? But yeah, couldn't use whatever functionality is exposed by passing a non-None value.

I couldn't make `None` work. Still, would like to have the support for DWARF v5 and will need this interface.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109412/new/

https://reviews.llvm.org/D109412



More information about the llvm-commits mailing list