[PATCH] D109481: [WebAssembly] Custom optimization for truncate

Thu Sep 9 17:02:46 PDT 2021

tlively requested changes to this revision.
tlively added a comment.
This revision now requires changes to proceed.

Can you add tests for this to llvm/test/CodeGen/WebAssembly?

================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:2483
+  // Pack to the largest type possible:
+  // vXi64/vXi32 -> PACK*SDW and vXi16 -> PACK*SWB.
+  EVT InVT = MVT::i16, OutVT = MVT::i8;
----------------
It would be good to write out the transformation we are doing in terms of selection dag operations and WebAssembly instructions. I don't know what PACK*SDW and PACK*SWB mean.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109481/new/

https://reviews.llvm.org/D109481