[PATCH] D109553: [SCEV] Attempt to define what flags are legal on a SCEV

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Description makes sense to me.



================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:123
+  ///   loop.  If any operand is loop varying (per these definition rules),
+  ///   than the SCEVAddRec is defined only after all operands are defined.
+  /// * All other SCEVs are defined at the earlest point all operands are
----------------
I think we assert that the operands of an AddRec are loop-invariant, so the extra text isn't relevant.


================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:132
+  /// can trap) can be defined per these rules in regions where it would trap
+  /// at runtime.  A SCEV being defined does not require the existance of any
+  /// instruction within the defined scope.
----------------
Existence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109553/new/

https://reviews.llvm.org/D109553