[PATCH] D109217: [llvm-dwarfdump] Fix unsigned overflow when calculating stats

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 14:30:03 PDT 2021


dblaikie added a comment.

In D109217#2992699 <https://reviews.llvm.org/D109217#2992699>, @tschuett wrote:

> That is fine be me. I guess the point is a save way to collect statistics and give guidance to users when the results could be bad, in release and debug mode. I would argue that saturating integers are different and maybe more precise solution than going from uint32_t to uint64_t ...

Well, both, probably - support use cases that weren't supported before (binaries that were too large to fit in the existing stats) and, separately/additionally, some way of reporting overflow rather than reporting bogus values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109217/new/

https://reviews.llvm.org/D109217



More information about the llvm-commits mailing list