[PATCH] D109388: [AArch64][CostModel] Use cost of target trunc type when only use of a non-register sized load

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 14:02:48 PDT 2021


dmgreen added a comment.

> Would it make more sense to have a check for this on the outliner side, and make a special call to `getMemoryOpCost` for load to trunc instructions then?

Does this come up a lot? I would be surprised, I think it only makes a difference for > 64bit loads on AArch64? For 32bit architectures I could see it happening more.

I've no objections to it being in the backend costmodel, it sounds more correct for how llvm is set up right now, but as far as I understand it should apply to all backends equally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109388/new/

https://reviews.llvm.org/D109388



More information about the llvm-commits mailing list