[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3895
+      Opts.OpenMPTargetDebug = 1;
+  }
+
----------------
CUDANumSMs? 

Don't check for NVPTX/AMDGCN but only if the new runtime is used, if not emit a warning that the flag is useless and ignored without the new runtime.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:254
+
+  return GV;
+}
----------------
Linkage cannot be private, I think. It might be ok if we put it in the llvm.used global otherwise we should just make it external, which is probably best.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109544/new/

https://reviews.llvm.org/D109544