[PATCH] D108602: [RISCV] Initial support .insn directive for the assembler.

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked 2 inline comments as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:917
+// for known formats.
+def : InstAlias<".insn_r $opcode, $funct3, $funct7, $rd, $rs1, $rs2",
+                (InsnR uimm7:$opcode, uimm3:$funct3, uimm7:$funct7, AnyReg:$rd,
----------------
jrtc27 wrote:
> Will writing `.insn_r` in the source get picked up by this and thus expose this detail, or be regarded as an unknown directive and thus give an error?
It should be hidden. I've added a test to insn_invalid.s


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108602/new/

https://reviews.llvm.org/D108602