[PATCH] D108298: [NPM] Print '-passes' compatible string for built pipeline.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D108298#2992135 <https://reviews.llvm.org/D108298#2992135>, @aeubanks wrote:

> this doesn't work with the whole inliner cgscc pipeline (where most of the default simplification pipeline runs) because in ModuleInlinerWrapperPass::run we create a separate pass manager and run that
> @mtrofin this sort of stuff is why I didn't particularly like the construction of a separate pass manager in ModuleInlinerWrapperPass
>
> https://github.com/llvm/llvm-project/blob/124bcc1a139d744a71a82a89e90b5058573f2697/llvm/lib/Transforms/IPO/Inliner.cpp#L1049

I think we need clarity wrt NPM and the scenarios that are pertinent to it, this included, because otherwise wrapping pipeline components into passes, maybe naively/subjectively, is attractive (FWIW, I could swear it was an intention of the design). So we either think that that's an accidental design artifact, and we document why it shouldn't be leveraged, or we offer guidelines (or extension points) for implementing cases like this 'print'. @aeubanks , can you help us with this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108298/new/

https://reviews.llvm.org/D108298