[PATCH] D109470: Add "profiling" to the list of absl libraries.

Yitzhak Mandelbaum via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 10:35:48 PDT 2021


ymandel added a comment.

In D109470#2992161 <https://reviews.llvm.org/D109470#2992161>, @nilayvaish wrote:

> In D109470#2992119 <https://reviews.llvm.org/D109470#2992119>, @ymandel wrote:
>
>> Any idea if there's a test for this matcher that should be updated?
>
> I looked at the commit that most recently added a directory to this file: 114c9fa0e46f7bf1d05d92da70da116b19f16911 <https://reviews.llvm.org/rG114c9fa0e46f7bf1d05d92da70da116b19f16911>.  That one also did not update any tests.  I also looked for `isInAbseilFile` in the `clang-tools-extra` directory.  I did not find the function being used in any of the tests.

Yeah, that was my impression as well. Alas. In that case, I think it's fine to commit as is. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109470/new/

https://reviews.llvm.org/D109470



More information about the llvm-commits mailing list