[PATCH] D108903: [llvm-reduce] Add reduce operands pass

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 10:19:47 PDT 2021


aeubanks added a comment.

Sorry for my bad communication, I was fine with doing what you wanted. That's what I meant with

In D108903#2988165 <https://reviews.llvm.org/D108903#2988165>, @aeubanks wrote:

> In D108903#2988164 <https://reviews.llvm.org/D108903#2988164>, @swamulism wrote:
>
>> In D108903#2988082 <https://reviews.llvm.org/D108903#2988082>, @aeubanks wrote:
>>
>>> Sure I suppose we can split up this patch
>>> @swamulism can you do that?
>>
>> Sure I can add `Constant::hasNullValue` and remove `ReduceOperands::typeIsNullable` in a separate patch
>
> I meant the part about reducing to undef vs null. `Constant::hasNullValue()` should be in this patch




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108903/new/

https://reviews.llvm.org/D108903



More information about the llvm-commits mailing list