[PATCH] D109500: [openmp] Fix 51647, corrupt bitcode on amdgpu

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 08:11:26 PDT 2021


jdoerfert added a comment.

Remove the target triple from
 llvm/test/Transforms/OpenMP/custom_state_machines.ll
and run it once with --mtriple set to amd and once to ptx.
The check prefixes should be --check-prefixes=ALL,AMDGPU and --check-prefixes=ALL,NVPTX respectively



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3430
+        new AllocaInst(VoidPtrTy, (unsigned int)AddressSpace::Local,
+                       "worker.work_fn.addr", &Kernel->getEntryBlock().front());
     WorkFnAI->setDebugLoc(DLoc);
----------------
not address space local. `DataLayout::getAllocaAddrSpace`


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3456
+        WorkFnAI->getName() + ".generic", StateMachineBeginBB);
+    WorkFnAIGeneric->setDebugLoc(DLoc);
+
----------------
`if (WorkFnAI->getType()->getAS() != Generic) WorkFnAI = new ASCast... `


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109500/new/

https://reviews.llvm.org/D109500



More information about the llvm-commits mailing list