[PATCH] D109488: [X86] Adjust Keylocker store register num for encodekey128/256

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 08:08:23 PDT 2021


LuoYuanke added a comment.

In D109488#2991661 <https://reviews.llvm.org/D109488#2991661>, @craig.topper wrote:

> These stores aren’t going to handle memory. The encode instruction read from handle memory. The stores are to an array provided by the caller of the intrinsic that only exists because we can’t return multiple values in C. If you don’t store them then those values in the user array are unitialized.

The encodekey instruction generate key handler. User expect the buffer size of handler is 3*16 bytes for _mm_encodekey128_u32 and 4*16 for _mm_encodekey2568_u32. Storing extra data to the buffer either need extra instruction or need extra memory space for user.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109488/new/

https://reviews.llvm.org/D109488



More information about the llvm-commits mailing list