[PATCH] D109440: [InstCombine] remove a buggy set of zext-icmp transforms

Thu Sep 9 04:59:34 PDT 2021

spatel added a comment.

In D109440#2990118 <https://reviews.llvm.org/D109440#2990118>, @lebedev.ri wrote:

> LGTM on the basis of directly preventing an endless combine loop and de-uglifying `transformZExtICmp()` at the same time - that `DoTransform` is super bugprone.

Thanks! Yes, the DoTransform was blamed in D104567 <https://reviews.llvm.org/D104567> .
Also for reference, I added a fold to IR to mitigate a potential loss from this patch at:
a3c1669b1717 <https://reviews.llvm.org/rGa3c1669b1717545e16e33c0d7c147355f4912faa>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109440/new/

https://reviews.llvm.org/D109440