[PATCH] D109441: [FuncSpec] Don't specialise call sites that have the MinSize attribute set

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 04:24:05 PDT 2021


ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

LGTM with the comments addressed.



================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:663
+      if (CS.hasFnAttr(Attribute::MinSize))
+        continue;
 
----------------
We need to mark `AllConstant` as false before we continue. Otherwise it is possible that the original function may be considered as unreachable incorrectly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109441/new/

https://reviews.llvm.org/D109441



More information about the llvm-commits mailing list