[PATCH] D109493: [llvm-shlib] Fix the i686 MSVC triple check for listing symbols to export in LLVM-C.dll
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 9 01:50:19 PDT 2021
mstorsjo added inline comments.
================
Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:127
# The python script needs to know whether symbols are prefixed with underscores or not.
- if(LLVM_HOST_TRIPLE STREQUAL "i686-pc-win32")
+ if(LLVM_HOST_TRIPLE STREQUAL "i686-pc-windows-msvc")
set(GEN_UNDERSCORE "--underscore")
----------------
I guess one could try to generalize this into matching `i*86-*win*` or something like that too...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109493/new/
https://reviews.llvm.org/D109493
More information about the llvm-commits
mailing list