[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 00:42:32 PDT 2021


c-rhodes created this revision.
c-rhodes added a reviewer: jansvoboda11.
Herald added a subscriber: dang.
c-rhodes requested review of this revision.
Herald added projects: clang, LLVM.
Herald added a subscriber: cfe-commits.

Identified in D109359 <https://reviews.llvm.org/D109359>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109489

Files:
  clang/include/clang/Driver/Options.td
  llvm/include/llvm/Option/OptParser.td


Index: llvm/include/llvm/Option/OptParser.td
===================================================================
--- llvm/include/llvm/Option/OptParser.td
+++ llvm/include/llvm/Option/OptParser.td
@@ -214,7 +214,7 @@
 }
 
 // Implementation detail of BoolOption.
-class MarshallingInfoBooleanFlag<KeyPathAndMacro kpm, code defaultvalue, code value, code name,
+class MarshallingInfoBooleanFlag<KeyPathAndMacro kpm, code defaultvalue, code value,
                                  code other_value, code other_name>
   : MarshallingInfoFlag<kpm, defaultvalue> {
   code Normalizer = "makeBooleanOptionNormalizer("#value#", "#other_value#", OPT_"#other_name#")";
Index: clang/include/clang/Driver/Options.td
===================================================================
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -407,8 +407,7 @@
                         Default default>
   : Flag<["-"], flag.Spelling>, Flags<flag.OptionFlags>, HelpText<flag.Help>,
     MarshallingInfoBooleanFlag<kpm, default.Value, flag.ValueAsCode,
-                               flag.RecordName, other.ValueAsCode,
-                               other.RecordName>,
+                               other.ValueAsCode, other.RecordName>,
     ImpliedByAnyOf<implied.ImpliedBy, implied.ValueAsCode> {}
 
 // Generates TableGen records for two command line flags that control the same


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109489.371519.patch
Type: text/x-patch
Size: 1403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210909/d9594e45/attachment.bin>


More information about the llvm-commits mailing list