[PATCH] D109423: [PowerPC] Reduce number of virtual registers used when eliminating frameindex

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 00:23:59 PDT 2021


lkail abandoned this revision.
lkail added a comment.

I just realized this was designed in purpose https://github.com/llvm/llvm-project/commit/d8a423cd71bb2a9b7666fd58fc82db16b4666d1d, though I don't know the motivation to keep it SSA, I'll abandon this patch first.

> nice conceptual abstraction that code we add only defines each virtual register once

I agree with it. But in other way, we can still `assert(!MRI->isSSA())` here and define virtual registers more than once.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109423/new/

https://reviews.llvm.org/D109423



More information about the llvm-commits mailing list