[PATCH] D107216: Revert [MC][ELF] Emit separate unique sections for different flags

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 21:36:42 PDT 2021


MaskRay added a comment.

Applying this patch. `git revert -n 165321b3d27de5349520b5fdb7e08cbd238c880f` seems to have merge conflicts.

But I'd definitely reword the commit message since the current one is unfair to the functional fix IMO:

Rust has a fragile embed-bitcode implementation (https://github.com/rust-lang/rust/blob/bddb59cf07efcf6e606f16b87f85e3ecd2c1ca69/compiler/rustc_codegen_llvm/src/back/write.rs#L970-L1017) which relied on the previous LLVM MC behavior.
Rust's LLVM fork has carried a revert. This commit made the similar revert to help distributions since they would otherwise probably carry a similar patch (as they ship rust linked against system LLVM).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107216/new/

https://reviews.llvm.org/D107216



More information about the llvm-commits mailing list