[PATCH] D109476: [APInt.h] Reduce the APInt header file interface a bit. NFC

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 21:21:11 PDT 2021


lattner added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5135
+namespace {
+/// Magic data for optimising signed division by a constant.
+struct ms {
----------------
craig.topper wrote:
> Will this end up being needed by GlobalISel? Is there a better place we could share?
Good question.  If so, it should go in `lib/CodeGen` somewhere.  I haven't been following GlobalISel, so I'm not sure where they are putting shared utilities between the two frameworks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109476/new/

https://reviews.llvm.org/D109476



More information about the llvm-commits mailing list