[PATCH] D109434: [X86][AVX] Add missing X86ISD::VBROADCAST(128->256) isel patterns for AVX1 targets

[Bing Yu via Phabricator via llvm-commits]

yubing added inline comments.


================
Comment at: llvm/test/CodeGen/X86/combine-concatvectors.ll:44
+
+define void @concat_of_broadcasts() {
+; AVX1-LABEL: concat_of_broadcasts:
----------------
RKSimon wrote:
> yubing wrote:
> > Thanks for creating this bugfix. This case only cover the code:
> > 
> > ```
> >   def : Pat<(v4f64 (X86VBroadcast v2f64:$src)),
> >             (VINSERTF128rr (INSERT_SUBREG (v4f64 (IMPLICIT_DEF)),
> >               (v2f64 (VMOVDDUPrr VR128:$src)), sub_xmm),
> >               (v2f64 (VMOVDDUPrr VR128:$src)), 1)>;
> > ```
> > I think we'd better add more cases.
> Its proving tricky to create tests for the other types, what about just adding this one isel pattern initially?
I am OK with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109434/new/

https://reviews.llvm.org/D109434