[PATCH] D99170: [CMake] try creating symlink first on windows

Dmitry Babokin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 16:13:04 PDT 2021


dbabokin added a comment.

I confirm that it is a problem with 7zip, which is not preserving symlinks by default. Thanks for pointing to it.
The reason why this commit "broke" it for us, is because it introduced symlinks on Windows.
I'm still not sure that using symlinks on Windows is a good idea, given how poorly they are supported by the ecosystem.

For those who have similar issue - we end up using tar format produced by "7z a -ttar -snl" (-snl is essential) and then wrapped it by regular 7z.
Note, stock "tar" on Windows doesn't handle symlinks out of the box.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99170/new/

https://reviews.llvm.org/D99170



More information about the llvm-commits mailing list