[PATCH] D107216: Revert [MC][ELF] Emit separate unique sections for different flags

Wed Sep 8 16:07:35 PDT 2021

MaskRay added a comment.

In D107216#2990511 <https://reviews.llvm.org/D107216#2990511>, @cuviper wrote:

> Rust's LLVM fork has the revert, but this is still going to be a problem for Rust with system LLVM 13. Do we have a way forward for this release? A revert seems to be a safer path than trying to develop something new in short time.
>
> Even if the former behavior wasn't guaranteed, it still worked well enough in practice, so right now we have a functional regression.

Rust abused the previous LLVM behavior when an inline asm `.section` directive can override the section attributes of `section ".llvmbc"`.
LLVM doesn't provide such guarantee.

I have made a suggestion that: Rust can try other approaches, e.g. replacing mixed module asm & rustc.embedded.module with pure module asm (.ascii "abc" or .incbin "file").
Have you tried it?

@cuviper Not exploring a proper approach forward, but just trigger-happily reverting a correct change and breaking the original author (and others)' workflow is not IMHO the correct approach.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107216/new/

https://reviews.llvm.org/D107216