[PATCH] D108877: [WebAssembly] Allow import and export of TLS symbols between DSOs

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 15:23:56 PDT 2021


tlively added inline comments.


================
Comment at: lld/wasm/SyntheticSections.cpp:70
+  // exports we are providing to the dynamic linker.  Currently this is only the
+  // case for TLS symbols where the exported value is relative toe __tls_base
+  // rather than __memory_base.
----------------
"toe" => "to"


================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:365-366
+      while (Count--) {
+        /*name*/ readString(Ctx);
+        /*flags*/ readVaruint32(Ctx);
+      }
----------------
Do we need to be storing this information somewhere so it can be round-tripped?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108877/new/

https://reviews.llvm.org/D108877



More information about the llvm-commits mailing list