[PATCH] D109462: [ARM] Remove unnecessary use of replaceSymbolicStrideSCEV (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 13:51:36 PDT 2021


fhahn created this revision.
fhahn added reviewers: anwel, dmgreen, SjoerdMeijer.
Herald added subscribers: javed.absar, hiraditya, kristof.beyls.
fhahn requested review of this revision.
Herald added a project: LLVM.

When passing an empty strides map, there's nothing to replace for
replaceSymbolicStrideSCEV and it just returns the SCEV for Ptr. There
should be no need to call the function.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109462

Files:
  llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp


Index: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
===================================================================
--- llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
+++ llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
@@ -2080,8 +2080,7 @@
           // least if they are loop invariant.
           // TODO: Loop variant strides should in theory work, too, but
           // this requires further testing.
-          const SCEV *PtrScev =
-              replaceSymbolicStrideSCEV(PSE, llvm::ValueToValueMap(), Ptr);
+          const SCEV *PtrScev = PSE.getSE()->getSCEV(Ptr);
           if (auto AR = dyn_cast<SCEVAddRecExpr>(PtrScev)) {
             const SCEV *Step = AR->getStepRecurrence(*PSE.getSE());
             if (PSE.getSE()->isLoopInvariant(Step, L))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109462.371436.patch
Type: text/x-patch
Size: 769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210908/2b0b0f5d/attachment.bin>


More information about the llvm-commits mailing list