[PATCH] D108457: [hwasan] Do not instrument accesses to uninteresting allocas.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 13:05:30 PDT 2021


eugenis added a comment.

still missing test cases for combinations of mixed safe/unsafe accesses



================
Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:69
   const InfoTy &getInfo() const;
+  const std::map<const Instruction *, bool> &getAccesses() const;
 
----------------
you want either DenseMap or SmallPtrSet here. std::map is unnecessarily ordered, logarithmic, and wastes memory


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108457/new/

https://reviews.llvm.org/D108457



More information about the llvm-commits mailing list