[PATCH] D109359: [TableGen] Optionally emit a warning for unused template args

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 12:57:22 PDT 2021


c-rhodes added a comment.

In D109359#2989874 <https://reviews.llvm.org/D109359#2989874>, @lattner wrote:

> This is a really great feature, my suggestions:
>
> 1. We should clean up the existing warnings before landing this patch.
> 2. This should be on for LLVM when it lands, and we should remove the -W flag that controls it after the rest of the ecosystem (MLIR etc) has a chance to adapt to this.
>
> I love this!

Thanks for the comments! I think that's a sensible way to move forward, I'll ping the owners of the backends that still have warnings and fix up what I can.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109359/new/

https://reviews.llvm.org/D109359



More information about the llvm-commits mailing list