[PATCH] D109192: [WIP/DNM] Support: introduce public API annotation support

Wed Sep 8 11:29:16 PDT 2021

compnerd added a comment.

In D109192#2990039 <https://reviews.llvm.org/D109192#2990039>, @echristo wrote:

> Hi Saleem,
>
> I think I understand where you're going, but I think this deserves a writeup and consideration on llvm-dev with your desired endpoint for the source base and what changes to both current and future development will need to happen with some benefits and costs outlined. Might want to include a "support story" for the project along these lines as well - or at least be clear that this doesn't change or affect what long term APIs we are willing to support.
>
> Thoughts?

I think that is inline with what I had expected.  I actually asked @rnk about his thoughts on this as well, and he was of the opinion that this wouldn't be a big surprise and to send out a proposed change first.  I wanted to get through LLVMSupport to the point that it would be possible to show what an approach for enabling a shared library build that could support all the platforms would look like.  I don't have any concerns with sending out a small write up of what the changes once at least the Windows pre-commit CI is green.  I already had expected to have to do that subsequently as I don't expect to tackle LLVM in a single change.  I had expected this to serve as a preparatory change to discuss the necessary changes for permitting `LLVM_ENABLE_DYLIB` builds on Windows.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109192/new/

https://reviews.llvm.org/D109192