[PATCH] D109419: [GlobalISel] Implement merging of stores of truncates.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:76-80
+  bool NeedBSwap;
+  bool NeedRotate;
+  Register WideSrcVal;
+  GStore *LowestIdxStore;
+  SmallVector<GStore *> FoundStores;
----------------
aemerson wrote:
> arsenm wrote:
> > Reverse the order of the fields?
> Why?
They're currently ordered to maximize padding. I also don't think the NeedBSwap and NeedRotate would be the most important fields (also they should get default initializers)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109419/new/

https://reviews.llvm.org/D109419