[PATCH] D109419: [GlobalISel] Implement merging of stores of truncates.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:83
+
+using BuildFnTy = std::function<void(MachineIRBuilder &)>;
+
----------------
paquette wrote:
> Looks like this part isn't used in the change?
Yeah I initially used it but then changed it later. I'll commit this as a separate NFC change.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3937
+    }
+    if (BaseReg != NewBaseReg)
+      break;
----------------
paquette wrote:
> maybe not for this patch, but maybe we should have a specific register matcher?
Yeah that would be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109419/new/

https://reviews.llvm.org/D109419