[PATCH] D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added a comment.

@aeubanks looked up the use of this pass, and the comments next to its usage say:

  // FIXME: The BarrierNoopPass is a HACK! The inliner pass above implicitly
  // creates a CGSCC pass manager, but we don't want to add extensions into
  // that pass manager. To prevent this we insert a no-op module pass to reset
  // the pass manager to get the same behavior as EP_OptimizerLast in non-O0
  // builds. The function merging pass is

Also this pass seems to only be declared and used as part of the "IPO transformations library", does it make sense for Wasm to depend on that? Or should I be making my own empty barrier pass? Is that still "cleaner" than what I have done here (naturally make it part of the semantics of the pass that actually does the work) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109202/new/

https://reviews.llvm.org/D109202