[PATCH] D109425: [MC] Add Subtarget for MAsmParser call to emitCodeAlignment
Eric Astor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 8 07:30:51 PDT 2021
epastor added a comment.
In D109425#2989346 <https://reviews.llvm.org/D109425#2989346>, @peter.smith wrote:
> In D109425#2989305 <https://reviews.llvm.org/D109425#2989305>, @epastor wrote:
>
>> This code is similar to code in AsmParser.cpp (https://github.com/llvm-mirror/llvm/blob/master/lib/MC/MCParser/AsmParser.cpp#L3344-L3351) - looks like that will probably need an update as well, to keep MaxBytesToFill from being interpreted as a pointer?
>
> Yes, I managed to catch that one in D45961 <https://reviews.llvm.org/D45961> that reference from llvm-mirror might be a little bit out of date. I think https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCParser/AsmParser.cpp#L3457 is where the code is now. Hope I've not missed something.
Great, looks good!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109425/new/
https://reviews.llvm.org/D109425
More information about the llvm-commits
mailing list