[PATCH] D109436: [RISCV] Fix Machine Outliner jump table handling.

[Yvan Roux via Phabricator via llvm-commits]

yroux created this revision.
yroux added reviewers: lewis-revill, apazos, lenary, luismarques, paquette, asb.
Herald added subscribers: vkmr, frasercrmck, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya.
yroux requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

Don't outline machine instructions which are using jump table indexes since they are materialized as local labels (like the already handled case of constant pools).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109436

Files:
  llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
  llvm/test/CodeGen/RISCV/machineoutliner-jumptable.mir


Index: llvm/test/CodeGen/RISCV/machineoutliner-jumptable.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/machineoutliner-jumptable.mir
@@ -0,0 +1,65 @@
+# RUN: llc -march=riscv32 -x mir -run-pass=machine-outliner -simplify-mir -verify-machineinstrs < %s \
+# RUN: | FileCheck -check-prefix=RV32I-MO %s
+# RUN: llc -march=riscv64 -x mir -run-pass=machine-outliner -simplify-mir -verify-machineinstrs < %s \
+# RUN: | FileCheck -check-prefix=RV64I-MO %s
+
+--- |
+  ; Cannot outline instructions with jump-table index operands
+  define i32 @foo(i32 %a, i32 %b) #0 { ret i32 0 }
+
+...
+---
+name:            foo
+tracksRegLiveness: true
+jumpTable:
+  kind:            block-address
+  entries:
+    - id:              0
+      blocks:          [ '%bb.0', '%bb.1', '%bb.2', '%bb.3' ]
+body:             |
+  bb.0:
+    liveins: $x10, $x11
+    ; RV32I-MO-LABEL: name: foo
+    ; RV32I-MO: $x5 = PseudoCALLReg {{.*}} @OUTLINED_FUNCTION_0
+    ; RV32I-MO: $x12 = LUI target-flags(riscv-hi) %jump-table.0
+    ; RV32I-MO: $x12 = ADDI $x12, target-flags(riscv-lo) %jump-table.0
+    ;
+    ; RV64I-MO-LABEL: name: foo
+    ; RV64I-MO: $x5 = PseudoCALLReg {{.*}} @OUTLINED_FUNCTION_0
+    ; RV64I-MO: $x12 = LUI target-flags(riscv-hi) %jump-table.0
+    ; RV64I-MO: $x12 = ADDI $x12, target-flags(riscv-lo) %jump-table.0
+
+    $x11 = ORI $x11, 1023
+    $x12 = ADDI $x10, 17
+    $x11 = AND $x12, $x11
+    $x10 = SUB $x10, $x11
+    $x12 = LUI target-flags(riscv-hi) %jump-table.0
+    $x12 = ADDI $x12, target-flags(riscv-lo) %jump-table.0
+    PseudoBR %bb.3
+
+  bb.1:
+    liveins: $x10, $x11
+
+    $x11 = ORI $x11, 1023
+    $x12 = ADDI $x10, 17
+    $x11 = AND $x12, $x11
+    $x10 = SUB $x10, $x11
+    $x12 = LUI target-flags(riscv-hi) %jump-table.0
+    $x12 = ADDI $x12, target-flags(riscv-lo) %jump-table.0
+    PseudoBR %bb.3
+
+  bb.2:
+    liveins: $x10, $x11
+
+    $x11 = ORI $x11, 1023
+    $x12 = ADDI $x10, 17
+    $x11 = AND $x12, $x11
+    $x10 = SUB $x10, $x11
+    $x12 = LUI target-flags(riscv-hi) %jump-table.0
+    $x12 = ADDI $x12, target-flags(riscv-lo) %jump-table.0
+    PseudoBR %bb.3
+
+  bb.3:
+    PseudoRET
+
+...
Index: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
+++ llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
@@ -1126,7 +1126,7 @@
 
   // Make sure the operands don't reference something unsafe.
   for (const auto &MO : MI.operands())
-    if (MO.isMBB() || MO.isBlockAddress() || MO.isCPI())
+    if (MO.isMBB() || MO.isBlockAddress() || MO.isCPI() || MO.isJTI())
       return outliner::InstrType::Illegal;
 
   // Don't allow instructions which won't be materialized to impact outlining


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109436.371329.patch
Type: text/x-patch
Size: 2800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210908/7cfe4ec4/attachment.bin>