[PATCH] D109053: [BitcodeReader] Delay select until all constants resolved
guopeilin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 8 05:20:03 PDT 2021
guopeilin added inline comments.
================
Comment at: llvm/lib/Bitcode/Reader/ValueList.cpp:155
ResolveConstants.pop_back();
-
+ if (Placeholder == RealVal)
+ continue;
----------------
efriedma wrote:
> Why is this change necessary? If we're sticking a value into ResolveConstants that isn't a placeholder, something has gone wrong, I think.
In the previous patch, which we parse select repeatedly, will generate some cases that placeholder become the exact RealVal.
However, in the new patch, this is not need any more.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109053/new/
https://reviews.llvm.org/D109053
More information about the llvm-commits
mailing list